Remove dependency on dfs-datastores#1473
Merged
ianoc merged 4 commits intotwitter:developfrom Jan 20, 2016
Merged
Conversation
Merge from twitter/scalding
Collaborator
|
+1 to this. For Pail fans, they can import the code into their project or migrate to: https://github.com/twitter/scalding/blob/develop/scalding-core/src/main/scala/com/twitter/scalding/typed/PartitionedTextLine.scala (since we assume there are few, if any). |
Collaborator
|
This looks pretty good to me, it would be great to 'scalaize' it, would be shorter and easier to read. But i think we could keep that for future clean up work as a noobie issue really |
rubanm
changed the title
rubanm
changed the title
Contributor
Author
|
Test runs done. Also fixed a bug in the store cleanup method (it was double-adding datasets with both version suffix and success files). |
Collaborator
|
👍 will wait for Ian to merge |
ianoc
added a commit
that referenced
this pull request
Jan 20, 2016
Remove dependency on dfs-datastores
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change copies over the VersionedStore code from dfs-datastores, and drops our dependency on dfs-datastores. This helps remove some dependencies for the upgrade path to Cascading 3.
https://github.com/nathanmarz/dfs-datastores/blob/master/dfs-datastores/src/main/java/com/backtype/hadoop/datastores/VersionedStore.java
Pending:Test runs on some real jobs using VersionedKeyValSource.
Open question:This change currently drops the PailSource.scala file altogether. Should we:
2 would be ideal but we'll need to provide a good way for users to migrate away.